Rename doenetMediaUrl prop to doenetImagesUrl - #46
Merged
Conversation
Mirror DoenetML#1485, which renamed the `doenetMediaUrl` prop (the `<image source="doenet:…">` resolution base) to `doenetImagesUrl`. Thread the new name through ActivityViewer → Viewer → Activity → SingleDocActivity to each embedded `<DoenetViewer>`, and bump @doenet/doenetml-iframe to 0.7.20-dev.334 so the underlying viewer accepts the renamed prop. No deprecation, as the old name was never released. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors DoenetML#1485, which renamed the
doenetMediaUrlprop todoenetImagesUrl(the base URL used to resolve<image source="doenet:…">references).Changes
doenetMediaUrlprop todoenetImagesUrlthroughout, threading the new name throughActivityViewer→Viewer→Activity→SingleDocActivityto each embedded<DoenetViewer>.@doenet/doenetml-iframe0.7.20-dev.332→0.7.20-dev.334, the newest dev version, so the underlying viewer accepts the renamed prop.ActivityViewer.viewerUrlscomponent test to the new prop name.No deprecation of the old name, since it was never released.
Verification
tsc, eslint, and prettier pass on the changed files.ActivityViewer.viewerUrlscypress component test passes, confirmingdoenetImagesUrlstill forwards end-to-end into the embedded viewer's iframesrcdoc.🤖 Generated with Claude Code